Mark classes of deprecated messages with @Deprecated. #876
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
vyazelenko reviewed Nov 10, 2021
| <?xml version="1.0" encoding="UTF-8" standalone="yes"?> | ||
| <sbe:messageSchema xmlns:sbe="http://fixprotocol.io/2016/sbe" | ||
| package="since-deprecated" | ||
| package="since.deprecated" |
There was a problem hiding this comment.
This change breaks the C# build (see https://github.com/real-logic/simple-binary-encoding/runs/4171818266?check_suite_focus=true):
Error: SinceDeprecatedTests.cs(72,49): error CS0103: The name 'SinceDeprecated' does not exist in the current context [/home/runner/work/simple-binary-encoding/simple-binary-encoding/csharp/sbe-tests/sbe-tests.csproj] Error: SinceDeprecatedTests.cs(73,49): error CS0103: The name 'SinceDeprecated' does not exist in the current context [/home/runner/work/simple-binary-encoding/simple-binary-encoding/csharp/sbe-tests/sbe-tests.csproj] 0 Warning(s) 42 Error(s) There was a problem hiding this comment.
I see, sorry. Then I create a separate XML for this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Implementation of #875
Wondering is something similar would make sense for fields?