Skip to content

Conversation

@billsegall
Copy link
Contributor

No description provided.

Constant enums were incorrectly being indexed in messages as for for non-constant enums. The getter now returns a constant value and the setter is removed.
@mjpt777 mjpt777 merged commit 5baf755 into aeron-io:master Jun 27, 2018
@mjpt777
Copy link
Contributor

mjpt777 commented Jun 27, 2018

Thanks

@billsegall billsegall deleted the Issue560.CSharp branch June 27, 2018 05:10
@dxwu88
Copy link

dxwu88 commented Jun 27, 2018

I used sbe-all-1.8.1,jar tool to generate C++ code for CME latest templates_FixBinary.xml. But the code doesn't work well. A couple of places have memory boundary issues. Does anyone have the same experience or know what the problem is? Thanks!

@mjpt777
Copy link
Contributor

mjpt777 commented Jun 27, 2018

@dxwu88 It is likely to be related to this PR. Can you test with the latest build?

@dxwu88
Copy link

dxwu88 commented Jun 27, 2018

Sure. Thanks!

@dxwu88
Copy link

dxwu88 commented Jun 27, 2018

For CME group message MDIncrementalRefreshBook46 &wrapForDecode( char *buffer, const std::uint64_t offset, const std::uint64_t actingBlockLength, const std::uint64_t actingVersion, const std::uint64_t bufferLength), what should I specified for arguments actingBlockLength and bufferLength? Thanks! 
@mjpt777
Copy link
Contributor

mjpt777 commented Jun 28, 2018

@dxwu88 It is not helpful to asked questions on PRs that do not help provide clarity on the PR. Best to raise questions as separate issues when unrelated.

To quickly answer the question from the above, the actingBlockLength is provided from decoding the message header. You can understand this by reading the SBE specification and following the examples. The bufferLength is provided as the length of the underlying buffer for bounds checking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants