This repository was archived by the owner on Oct 22, 2021. It is now read-only.
Handle object and array value expressions better. #8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Totally rewrite how parsing of the full expression is done. Splitting by a regex would have been too complex and this solution is a safer one and easier to maintain. According to the tests it will handle any single variable, array or object literal as a value expression.
tregusti force-pushed the feature/array-object-expressions branch from c6ad123 to 49db55a Compare 
| Thanks a lot for this! m-m-m murgin' |
kasperlewau added a commit that referenced this pull request Aug 31, 2015
Handle object and array value expressions better.
This was referenced Aug 31, 2015
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Totally rewrite how parsing of the full expression is done. Splitting by
a regex would have been too complex and this solution is a safer one and
easier to maintain.
According to the tests it will handle any single variable, array or object
literal as a value expression.
Will hopefully solve #4.