This repository was archived by the owner on Oct 22, 2021. It is now read-only.
Handle ternary operators and angular filters with arguments #25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hey man, cheers for the PR! Would you mind writing up some unit tests covering these new cases before merging? For reference, here are the contributing guidelines. |
| @AntoineEsteve What's the status on this one? |
| I'll go ahead and close this for the time being given that #26 was just merged and released, which partly(fully?) takes care of the changes requested. |
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
The current version doesn't allow to use the angular-bind-notifier with ternary operators and filters with arguments.
First case, ternary operators :
{{:namespace:(varA?varB:varC)}}varA?varBis not a namespace, it is part of the expression.Other case, filters with arguments :
{{:namespace:(varA|orderBy:varB:varC)}}(varA|orderByis not a namespace, it is part of the expression.