This repository was archived by the owner on Oct 22, 2021. It is now read-only.
fix(dynamicWatcher): watchDelegate.length check #15
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
kasperlewau force-pushed the fix/broken-notifications branch 2 times, most recently from e953164 to ed8e45d Compare 
Checking the name of the given watchDelegate does not play well with a minified version of Angular. However, checking on the amount of expected arguments on the given watchDelegate we can rule out cases where we are not dealing with a oneTimeWatchDelegate.
kasperlewau force-pushed the fix/broken-notifications branch from ffc85f1 to af33308 Compare kasperlewau changed the title kasperlewau added a commit that referenced this pull request Oct 28, 2015
fix(dynamicWatcher): watchDelegate.length check
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Checking the name of the watchDelegate does not play well with a minified source. Checking the length of the given watchDelegate (the amount of parameters), we can rule out cases where we are not dealing with a oneTimeWatchDelegate.
A better solution to this problem has to be be out there, somewhere.
Closes #14