This repository was archived by the owner on Oct 22, 2021. It is now read-only.
Fix/exponential listeners #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| hmph. false positive. |
kasperlewau force-pushed the fix/exponential-listeners branch from 44ea248 to 287cd76 Compare By checking truthiness of the given prototype (yup. wtf.) in the dynamicWatcher we're either: * hiding the problem or * restricting the registration of $on listeners to oneTimeWatchDelegate's This needs some more testing.
kasperlewau force-pushed the fix/exponential-listeners branch from 287cd76 to 03cc20f Compare | cleaned it up a wee bit, now the tests are passing as well as manual testing in the wild. ... should probably add some Chrome/FF/etc launchers for the test runs to ensure compatibility. |
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
not really liking this one.
$$listenersdied but, meh.ref issue: #5