Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Conversation

@sikelio
Copy link
Contributor

@sikelio sikelio commented Jan 3, 2024

Based from the .gitignore collection of GitHub : https://github.com/github/gitignore/blob/main/Node.gitignore

Proposed changes

Describe the big picture of your changes here to communicate to the maintainers why we should accept this pull request. If it fixes a bug or resolves a feature request, be sure to link to that issue.

The .gitignore file does not contain enough file to exclude from pushing to git, like yarn or npm log who can contain personal information like

  • The real name of the owner machine
  • All path set up on the machine

Types of changes

What types of changes does your code introduce?

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@Julien-R44 Julien-R44 merged commit 68cf6b8 into adonisjs-community:develop Jan 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants