Skip to content
This repository was archived by the owner on Jan 23, 2025. It is now read-only.

Conversation

@McSneaky
Copy link

Proposed changes

Webpack encore is missing when creating new web project and you select Encore

image

image

@symfony/webpack-encore is missing from package.json

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works.
  • I have added necessary documentation (if appropriate)

Further comments

I'm unsure if that's correct way to do it 😅

@McSneaky
Copy link
Author

Used Github GUI to update files. Please be super-hyper critical when reviewing it :)

@thetutlage
Copy link
Member

WebPack is configured using AdonisJS assembler package. https://github.com/adonisjs/assembler/blob/develop/commands/Invoke.ts#L47

However, there was a error happening during install because of peer dependencies mis-match, which was swallowed by the command.

I have added fix for both the issues.

@thetutlage thetutlage closed this Nov 18, 2022
@McSneaky McSneaky deleted the patch-2 branch November 18, 2022 10:41
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

2 participants