Refactor column resizing for controlled state resizing #3672
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Build successful! 🎉 |
| Build successful! 🎉 |
| Build successful! 🎉 |
# Conflicts: # packages/@react-spectrum/table/src/TableView.tsx # packages/@react-stately/layout/src/TableLayout.ts
| Build successful! 🎉 |
…ctrum into refactor-column-resizing
| Build successful! 🎉 |
LFDanLu reviewed Dec 13, 2022
Member
LFDanLu left a comment
LFDanLu left a comment There was a problem hiding this comment.
Just two things I noticed when writing the docs, can be followup.
Comment on lines +18 to +22
| export type ColumnStaticSize = number | `${number}` | `${number}%`; // match regex: /^(\d+)(?=%$)/ | ||
| /** Widths that change size in relation to the remaining space and in ratio to other dynamic columns. */ | ||
| export type ColumnDynamicSize = `${number}fr`; // match regex: /^(\d+)(?=fr$)/ | ||
| /** All possible sizes a column can be assigned. */ | ||
| export type ColumnSize = ColumnStaticSize | ColumnDynamicSize; |
Member
There was a problem hiding this comment.
Just a heads up, I noticed that these types were malformed in the docs.
Looks like it is having a hard time understanding ${number}` | `${number}% and ${number}fr unfortunately
Member Author
There was a problem hiding this comment.
urgh, lol, i'll address it in followup
TODO: add to follow up
devongovett reviewed Dec 13, 2022
devongovett approved these changes Dec 13, 2022
snowystinger pushed a commit that referenced this pull request Dec 13, 2022
devongovett pushed a commit that referenced this pull request Dec 15, 2022
majornista pushed a commit that referenced this pull request Dec 16, 2022
majornista pushed a commit that referenced this pull request Jan 17, 2023
majornista pushed a commit that referenced this pull request Jan 19, 2023
majornista pushed a commit that referenced this pull request Jan 19, 2023
majornista pushed a commit that referenced this pull request Jan 25, 2023
majornista pushed a commit that referenced this pull request Jan 25, 2023
majornista pushed a commit that referenced this pull request Jan 25, 2023
majornista pushed a commit that referenced this pull request Jan 25, 2023
majornista pushed a commit that referenced this pull request Jan 25, 2023
majornista pushed a commit that referenced this pull request Jan 25, 2023
majornista pushed a commit that referenced this pull request Jan 25, 2023
majornista pushed a commit that referenced this pull request Jan 25, 2023
majornista pushed a commit that referenced this pull request Jan 26, 2023
reidbarber added a commit that referenced this pull request Jan 31, 2023
* fix(#2949): TableView Windows High Contrast issues * fix(#2949): ListView Windows High Contrast issues * fix(#2949): Drag and Drop Windows High Contrast issues * fix(#3672): refine Checkbox WHCM/forced-colors styles * fix(#3827): fix checkbox chromatic tests * fix(#3672): Move forced-colors color overrides to start of media-query * fix(#3672): remove some css specificity for forced-color overrides * fix(#3672): add vars for --spectrum-global-color-blue-500 * fix(#3672): fix checkbox forced-colors overrides * fix(#3672): fix circle loader forced-colors overrides * fix(#3672): fix dropzone forced-colors overrides * fix(#3672): fix switch forced-colors overrides * fix(#3672): fix table forced-colors overrides * fix(#3672): fix ListView forced-colors overrides * fix(#3672): ListView/Table add more code comments for forced-colors * fix(#3672): move forced-color-adjust statements to simplify media query overrides * fix(#3672): remove global variables from forced-colors overrides * fix border focus colors --------- Co-authored-by: Daniel Lu <dl1644@gmail.com> Co-authored-by: Robert Snow <rsnow@adobe.com> Co-authored-by: Reid Barber <reid@reidbarber.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Closes #3368
and supersedes #3529
✅ Pull Request Checklist:
📝 Test Instructions:
Table resizing should behave the same as it has from a user point of view. I've also added controlled stories, as well as aria examples (mouse only on the aria ones).
Internally, I've also added a number of tests. They are run against both the aria implementation and the rsp implementation.
🧢 Your Project: