Update startunicorn command to prevent spamming #632
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Hey, sorry I missed this -- thanks for the PR! This looks like it would fix the problem, but would it be cleaner to set |
| You are absolutely right, @adamghill . I made the change following your suggestion, much cleaner! But anyway, someday it might make sense to extract some logic from this loop. I mean, does not please me the idea of having such an extensive loop containing all logic. Makes sense? |
Yep, makes sense to me! I'd merge a PR if you want to extract that logic. |
| @adamghill, sorry for taking so long to reply this. You can close this PR, I've just sent another one |
| No worries, I know how it is! 😆 |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Greetings @adamghill !
I was following documentation and noticed that creating multiple components for the first time in an app results in an undesired loop (print below)
The changes I'm proposing fix that by checking the number of files in components folder. (print below)
Let me know if you need anything!