Skip to content

Espruino Pico: Remove settings for DNP oscillator #4719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 7, 2021
Merged

Espruino Pico: Remove settings for DNP oscillator #4719

merged 2 commits into from
May 7, 2021

Conversation

@hierophect
Copy link
Collaborator

@hierophect hierophect commented May 6, 2021

The LSE on the Espruino Pico is actually DNP, which isn't documented on the schematic. This was causing a clock failure after the 6.0 STM32 timekeeping reworks.

Resolves #4714
@hierophect hierophect added the stm label May 6, 2021
@hierophect hierophect requested a review from dhalbert May 6, 2021 17:56
@hierophect
Copy link
Collaborator Author

hierophect commented May 6, 2021

It appears the CI is failing for unrelated reasons on the ESP32-S2, nothing to do with this I don't think.
@dhalbert
Copy link
Collaborator

dhalbert commented May 6, 2021

It appears the CI is failing for unrelated reasons on the ESP32-S2, nothing to do with this I don't think.

Yeah, I fixed the build problem with #4721. This seems to happen every time there is some updated software on the build system VPS's.
@dhalbert
Copy link
Collaborator

dhalbert commented May 6, 2021

@hierophect Could you drop an Espruino Pico build in #4714 for the OP there to test? I thought I could point to an artifact, but I don't see any artifacts. Thanks.
@hierophect
Copy link
Collaborator Author

hierophect commented May 6, 2021

That's weird, don't they normally show up even when the build fails overall? Anyway yeah I can drop one over there.
@hierophect hierophect mentioned this pull request May 6, 2021
Closed
@dhalbert
Copy link
Collaborator

dhalbert commented May 6, 2021

That's weird, don't they normally show up even when the build fails overall? Anyway yeah I can drop one over there.

Yes, I am confused why they aren't there.
dhalbert
dhalbert approved these changes May 7, 2021
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out! And thanks to @valholl for testing!
@dhalbert dhalbert merged commit 2fe1df4 into adafruit:main May 7, 2021
@hierophect hierophect deleted the stm-espr-pico-fix branch May 7, 2021 15:30
@dhalbert dhalbert mentioned this pull request May 13, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

stm

2 participants

@hierophect @dhalbert