Fix Mac crash when waking up with an ejected CIRCUITPY #2653
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
We now correctly set the reason for the unit not being ready and always start the unit. Fixes micropython#2567
dhalbert approved these changes Feb 25, 2020
Collaborator
dhalbert left a comment
dhalbert left a comment There was a problem hiding this comment.
This looks good, though the test and mpy-cross subjobs are crashing. I re-ran the actions, but the same thing happened. Merge as you wish.
hathach approved these changes Feb 25, 2020
Member
hathach left a comment
hathach left a comment There was a problem hiding this comment.
macOS is so persistent to get the sense code, look perfect :D
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We now correctly set the reason for the unit not being ready and
always start the unit.
Fixes #2567