Async #97
Open
Async #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Hi,
I did some changes in order to avoid the blocking delay in the flow.
Basically I created a loop function that is called in the main loop.
It has an internal state machine for the operation. Clearly, the reading phase is done in a blocking way.
I tested it on my NodeMCU and WeMos board and it works fine.
I suggest to create a dedicated branch (like I did).
Maybe, in the future, a common solution (where the user can choise which method he prefers) can be done in order to get an unique library.
Regards,
Salvo