Skip to content

Conversation

@mrninhvn
Copy link
Contributor

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you for your PR. Could you confirm the VID/PID as review comment.

Comment on lines 56 to 58
#define USB_DESC_VID 0x7A79
#define USB_DESC_UF2_PID 0x0520
#define USB_DESC_CDC_ONLY_PID 0x0520
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you confirm this is the VID/PID assigned specifically for this board.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you confirm this is the VID/PID assigned specifically for this board.

7A79 is "zy" (zhiayang), I haven't seen this duplicated anywhere, but do you have any suggestions to be sure? Thank you.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot randomly pick an vid/pid. These ids are uniquely assigned by vendor for each product and this repo only accept one with valid vid/pid. You should try to apply for an vid/pid from other donor.

@mrninhvn
Copy link
Contributor Author

you cannot randomly pick an vid/pid. These ids are uniquely assigned by vendor for each product and this repo only accept one with valid vid/pid. You should try to apply for an vid/pid from other donor.

hmm, is there an easy way for me to get one? thank you.

@hathach
Copy link
Member

hathach commented Nov 12, 2021

you could apply for one https://pid.codes/

@zhiayang
Copy link

zhiayang commented Dec 7, 2021

I've got a PID now: 1209 / 7a01. pidcodes/pidcodes.github.com#701

@mrninhvn mrninhvn requested a review from hathach December 7, 2021 03:34
@mrninhvn
Copy link
Contributor Author

mrninhvn commented Dec 7, 2021

I've got a PID now: 1209 / 7a01. pidcodes/pidcodes.github.com#701

Thanks @zhiayang , I changed that.

Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

everything look good, only a minor change request to correct the board id format


#define UF2_PRODUCT_NAME "Mikoto nRF52840"
#define UF2_VOLUME_LABEL "MIKOTO-BOOT"
#define UF2_BOARD_ID "nRF52840-mikoto"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not picky but board id must follow uf2 spec https://github.com/microsoft/uf2#files-exposed-by-bootloaders . You need to add the board revision as well

The Board-ID field is machine-readable and consists of a number of dash-separated tokens. The first token is the CPU type, second is the board type, and third is the board revision. More tokens can be also added. 
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, I changed that.

@mrninhvn mrninhvn requested a review from hathach December 7, 2021 04:58
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

look good, it is ready to merge, though for board binary to be part of the release, the board need to be added to the ci as well https://github.com/adafruit/Adafruit_nRF52_Bootloader/blob/master/.github/workflows/githubci.yml#L27

@mrninhvn mrninhvn requested a review from hathach December 16, 2021 06:42
Copy link
Member

@hathach hathach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect now

@hathach hathach merged commit c0666e4 into adafruit:master Dec 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants