receive_time: fix week day #138
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
… of what is expected by Python. Implement a method to parse the dict returned by the server and correct the week day.
jwcooper approved these changes Nov 23, 2021
| Merging as 6587c92 will catch future requests failing with external forks, via https://dev.to/petrsvihlik/using-environment-protection-rules-to-secure-secrets-when-building-external-forks-with-pullrequesttarget-hci |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Fixes #137
Describe scope of change.
Implements a method to parse the dict returned by the server and correct the week day. Only the receive_time method is affected
Describe any known limitations with your change.
N/A
Please run any tests or examples that can exercise your modified code.
Updated test_time_data to verify week day and added a test for the new method that tests every day of the week.