Add ability to create feed within a group #125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ladyada approved these changes Dec 21, 2020
| I'm going to merge this in, it passes local and forked unit-tests and will pass on Unit-test failing looks similar to the previous PR, merging into master will authorize the CI script. Unittest fails to acknowledge the env secrets on PRs (https://github.com/adafruit/Adafruit_IO_Python/pull/125/checks?check_run_id=1590263116#step:7:8) v.s. when the action runs in I believe it's because "secrets are not passed to workflows that are triggered by a pull request from a fork". We would need to work off a branch for future pull-requests. < @dherrada Could you take a look at this/verify that I'm not missing something here? |
This was referenced Dec 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
API Endpoint: https://io.adafruit.com/api/docs/#create-feed-in-a-group
Addresses issues #104 and #118