Skip to content

Linted #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 5, 2021
Merged

Linted #39

merged 1 commit into from
Nov 5, 2021

Conversation

@evaherrada
Copy link
Collaborator

@evaherrada evaherrada commented Nov 5, 2021

No description provided.

@evaherrada evaherrada requested a review from a team November 5, 2021 21:48
@tekktrik tekktrik mentioned this pull request Nov 5, 2021
Merged
@kattni
Copy link
Contributor

kattni commented Nov 5, 2021

Looking into this import format.
@tekktrik
Copy link
Member

tekktrik commented Nov 5, 2021

Included the changes here into #40
@kattni kattni merged commit 409cda4 into main Nov 5, 2021
askpatrickw
askpatrickw approved these changes Nov 5, 2021
View reviewed changes
Copy link

@askpatrickw askpatrickw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Trust the linter: from package import module is more "pythonic" IMHO.
  2. Using min() as a single line of code instead of the if statements is a nice optimization
@askpatrickw askpatrickw deleted the patch-fix branch November 5, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants

@evaherrada @kattni @tekktrik @askpatrickw