Added interim over/underflow protection #16
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
caternuson approved these changes Nov 27, 2018
| merged! |
This was referenced Nov 27, 2018
tannewt pushed a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 28, 2018
Updating https://github.com/adafruit/Adafruit_CircuitPython_Se to 1.2.6 from 1.2.5: > DM: add delay for analog write on raspberry pi Updating https://github.com/adafruit/Adafruit_CircuitPython_TCS34725 to 3.1.2 from 3.1.1: > Merge pull request adafruit/Adafruit_CircuitPython_TCS34725#16 from microbuilder/overflowfix Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 3.3.1 from 3.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_HID#28 from dhalbert/consumer_control-mute
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This is related to #10 and #14, which should resolve divide by zero and 8-bit overflow conditions.
However, there are some fundamental problems with the algorithm(s) used here such as negative lux values being possible, and what appears to be a somewhat arbitrary conversion to 24-bit RGB color. I've previously implemented more accurate algorithms for these kinds of conversions, but this will require some work to port to CP and this PR will at least solve the current 0 and >255 issue as an interim solution.