Skip to content

Refinements for MCP2221 #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 10, 2021
Merged

Refinements for MCP2221 #9

Changes from 2 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
6a2063a
refinements for mcp2221
caternuson Feb 9, 2021
b507ba0
blinted
caternuson Feb 9, 2021
5af0f25
remove reset from init
caternuson Feb 10, 2021
1a63b9e
shushing example
caternuson Feb 10, 2021
081f2ee
example rename
caternuson Feb 10, 2021
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 14 additions & 3 deletions adafruit_scd30.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -63,9 +63,11 @@ def __init__(self, i2c_bus, ambient_pressure=0, address=SCD30_DEFAULT_ADDR):

self.reset()

# set continuous measurement interval in seconds
self.measurement_interval = 2
# activate automatic self-calibration
self.self_calibration_enabled = True
# sets ambient pressure and starts continuous measurements
# trigger continuous measurements with optional ambient pressure compensation
self.ambient_pressure = ambient_pressure

# cached readings
Expand All @@ -76,7 +78,14 @@ def __init__(self, i2c_bus, ambient_pressure=0, address=SCD30_DEFAULT_ADDR):
def reset(self):
"""Perform a soft reset on the sensor, restoring default values"""
self._send_command(_CMD_SOFT_RESET)
sleep(0.030) # not mentioned by datasheet, but required to avoid IO error
sleep(0.1) # not mentioned by datasheet, but required to avoid IO error
# pylint:disable=protected-access
# are we using Blinka?
if hasattr(self.i2c_device.i2c, "_i2c"):
Copy link
Member

@ladyada ladyada Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id kinda sorta prefer not having this here but instead in a new simple example just for mcp2221 if thats ok?
Copy link
Contributor Author

@caternuson caternuson Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we'd have to remove the call to reset() in __init__, which is maybe OK? otherwise you can't even instantiate with mcp2221.
Copy link
Member

@ladyada ladyada Feb 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.<
ridiculous sensor.
ok move the reset() out of init and into the example too
# with an MCP2221?
if hasattr(self.i2c_device.i2c._i2c, "_mcp2221"):
# then lets reset that too
self.i2c_device.i2c._i2c._mcp2221._reset()

@property
def measurement_interval(self):
Expand Down Expand Up @@ -108,6 +117,8 @@ def self_calibration_enabled(self):
@self_calibration_enabled.setter
def self_calibration_enabled(self, enabled):
self._send_command(_CMD_AUTOMATIC_SELF_CALIBRATION, enabled)
if enabled:
sleep(0.01)

@property
def data_available(self):
Expand Down Expand Up @@ -196,7 +207,7 @@ def temperature(self):
def relative_humidity(self):
"""Returns the current relative humidity in %rH.

**NOTE** Between measurements, the most recent reading will be cached and returned. """
**NOTE** Between measurements, the most recent reading will be cached and returned."""
if self.data_available:
self._read_data()
return self._relative_humidity
Expand Down