Skip to content

catch only the r/g/b values when list is longer #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 20, 2024
Merged

catch only the r/g/b values when list is longer #119

merged 1 commit into from
Feb 20, 2024

Conversation

@reza-n
Copy link
Contributor

@reza-n reza-n commented Dec 27, 2023

fixing an issue when 4 values are returned instead of r/g/b. Might be safer to always truncate the list to 3. Similar to issue #117

(0, 0, 0, 0) Traceback (most recent call last): File "/var/local/pproxy/git/home_device/usr/local/pproxy/tests/lcd_test.py", line 23, in <module> LCD.show_logo() File "/var/local/pproxy/git/home_device/usr/local/pproxy/tests/../lcd.py", line 284, in show_logo self.lcd.image(image, x, y) File "/var/local/pproxy/wepn-env/lib/python3.9/site-packages/adafruit_rgb_display/rgb.py", line 231, in image pix = color565(img.getpixel((i, j))) File "/var/local/pproxy/wepn-env/lib/python3.9/site-packages/adafruit_rgb_display/rgb.py", line 59, in color565 red, g, b = r ValueError: too many values to unpack (expected 3)
@reza-n
Update rgb.py
a4c6325 
fixing an issue when 4 values are returned instead of r/g/b
FoamyGuy
FoamyGuy approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, and Looks good to me. Thanks for the fix @reza-n!
@FoamyGuy FoamyGuy merged commit c545d3a into adafruit:main Feb 20, 2024
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 21, 2024
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@38b61d2)
4fe0f30 
Updating https://github.com/adafruit/Adafruit_CircuitPython_IRRemote to 4.1.19 from 4.1.18: > Merge pull request adafruit/Adafruit_CircuitPython_IRRemote#67 from Kry-Vosa/main Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.12.4 from 3.12.3: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#119 from reza-n/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_Seesaw to 1.16.3 from 1.16.2: > Merge pull request adafruit/Adafruit_CircuitPython_seesaw#126 from logandgsmith/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_asyncio to 1.3.1 from 1.3.0: > Merge pull request adafruit/Adafruit_CircuitPython_asyncio#64 from kbsriram/main Updating https://github.com/adafruit/Adafruit_CircuitPython_HID to 6.1.0 from 6.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_HID#124 from pythonmcpi/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_IterTools to 2.0.8 from 2.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_IterTools#20 from kbsriram/main Updating https://github.com/adafruit/Adafruit_CircuitPython_MiniMQTT to 7.5.9 from 7.5.8: > Merge pull request adafruit/Adafruit_CircuitPython_MiniMQTT#203 from justmobilize/simplify-socket-exceptions Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@reza-n @FoamyGuy