Skip to content

Fix issue #25 - add Adafruit-Blinka to requirements.txt #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 4, 2022
Merged

Fix issue #25 - add Adafruit-Blinka to requirements.txt #26

merged 3 commits into from
Oct 4, 2022

Conversation

@prcutler
Copy link
Contributor

@prcutler prcutler commented Oct 4, 2022 •
edited
Loading

Tekktrik, I just noticed you self assigned this. Hope you don't mind, sorry! Fix issue #25 - add Adafruit-Blinka to requirements.txt
@tekktrik
Copy link
Member

tekktrik commented Oct 4, 2022

Nope, not at all! I only self-assign since I tend to forget what isn't written down or in front of my face :) just wanted to make sure this got done, so very much appreciate you did it!
tekktrik
tekktrik requested changes Oct 4, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should happen in the root folder's requirements.txt. The one edited here is just for sphinx, whereas the one in the root folder is for the library functionally.
@tekktrik tekktrik linked an issue Oct 4, 2022 that may be closed by this pull request
Library missing Adafruit-Blinka requirement #25
Closed
@prcutler
Copy link
Contributor Author

prcutler commented Oct 4, 2022

I'm so sorry about that, should have paid better attention.
@tekktrik
Copy link
Member

tekktrik commented Oct 4, 2022

No worries, it's probably something we should actually mention in that file specifically, especially since they're identically named.
tekktrik
tekktrik approved these changes Oct 4, 2022
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thanks!
@tekktrik tekktrik merged commit 8bac84a into adafruit:main Oct 4, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 5, 2022
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@eaa233b)
e290146 
Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint to 2.2.10 from 2.2.9: > Merge pull request adafruit/Adafruit_CircuitPython_Fingerprint#49 from prcutler/issue32 Updating https://github.com/adafruit/Adafruit_CircuitPython_LTR329_LTR303 to 2.0.0 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_LTR329_LTR303#3 from caternuson/iss2 Updating https://github.com/adafruit/Adafruit_CircuitPython_SI1145 to 1.1.5 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_SI1145#15 from DeadSix27/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA8418 to 1.0.5 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_TCA8418#10 from prcutler/issue6 Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.5.6 from 2.5.5: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#58 from isacben/add-type-annotations-to-docstrings Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 3.0.8 from 3.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_NTP#26 from prcutler/issue25 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_BLE_File_Transfer
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@prcutler @tekktrik