Resolves Example file(s) missing sensor/library name #5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
FoamyGuy approved these changes Feb 9, 2020
There was a problem hiding this comment.
@BiffoBear Thanks for jumping in and helping out with the Library Infrastructure Issues!
FoamyGuy requested changes Feb 9, 2020
There was a problem hiding this comment.
@BiffoBear It looks like you've made a copy of the tap_detection.py file with the new proper name of lsm303_accel_tap_detection.py but also left the original tap_detection.py file in place. Can you please remove tap_detection.py and push again? You should see 4 files in the examples/ folder and they should all start with lsm303_accel
| Thanks for the quick review. The offending file has been deleted, and I've learned something along the way. |
ladyada approved these changes Feb 9, 2020
| thanks! |
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Feb 18, 2020
Updating https://github.com/adafruit/Adafruit_CircuitPython_ADS1x15 to 2.1.3 from 2.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_ADS1x15#52 from ares-est/master Updating https://github.com/adafruit/Adafruit_CircuitPython_CLUE to 2.0.3 from 2.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#17 from kattni/slideshow-fix > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#14 from dherrada/master > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#16 from kattni/slideshow-example > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#15 from kattni/add-display-object > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#12 from kattni/add-space > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#11 from kattni/variable-change > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#10 from kattni/level-bubble-fix > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#9 from kattni/color-fix > Merge pull request adafruit/Adafruit_CircuitPython_CLUE#8 from kattni/example-update Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint to 1.1.6 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_Fingerprint#11 from stitchesnburns/stitchesnburns-patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_LIS2MDL to 2.0.2 from 2.0.1: > Update README.rst Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303_Accel to 1.0.3 from 1.0.2: > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#5 from BiffoBear/rename-example-file > Merge pull request adafruit/Adafruit_CircuitPython_LSM303_Accel#4 from FoamyGuy/master Updating https://github.com/adafruit/Adafruit_CircuitPython_LSM303DLH_Mag to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_LSM303DLH_Mag#5 from FoamyGuy/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP230xx to 2.2.3 from 2.2.2: > Merge pull request adafruit/Adafruit_CircuitPython_MCP230xx#21 from foozmeat/master Updating https://github.com/adafruit/Adafruit_CircuitPython_MPU6050 to 1.0.4 from 1.0.3: > Merge pull request adafruit/Adafruit_CircuitPython_MPU6050#5 from FoamyGuy/master Updating https://github.com/adafruit/Adafruit_CircuitPython_PyPortal to 3.1.10 from 3.1.9: > Merge pull request adafruit/Adafruit_CircuitPython_PyPortal#65 from cogliano/master Updating https://github.com/adafruit/Adafruit_CircuitPython_RGB_Display to 3.8.9 from 3.8.8: > Merge pull request adafruit/Adafruit_CircuitPython_RGB_Display#70 from makermelissa/master Updating https://github.com/adafruit/Adafruit_CircuitPython_BluefruitConnect to 1.0.11 from 1.0.10: > Merge pull request adafruit/Adafruit_CircuitPython_BluefruitConnect#17 from caternuson/controller_example Updating https://github.com/adafruit/Adafruit_CircuitPython_BusDevice to 4.2.0 from 4.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_BusDevice#43 from dhalbert/avoid-alloc Updating https://github.com/adafruit/Adafruit_CircuitPython_Gizmo to 1.1.3 from 1.1.2: > Merge pull request adafruit/Adafruit_CircuitPython_Gizmo#10 from FoamyGuy/master Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_LPS2X
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Renamed 'tap_detection.py' to 'lsm303_accel_tap_detection.py'
No other changes.