Skip to content

Conversation

@dhalbert
Copy link
Contributor

This library uses a package folder, but setup.py assumed it was a single-file module.

@dhalbert dhalbert requested a review from a team March 29, 2021 01:33
Copy link
Contributor

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, makes sense from what I know of python packaging which admittedly is not a whole lot

@jepler
Copy link
Contributor

jepler commented Mar 29, 2021

jinx

@jepler jepler merged commit 21d5dfb into adafruit:main Mar 29, 2021
@dhalbert dhalbert deleted the setup-packages branch March 29, 2021 01:41
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Mar 29, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_EMC2101 to 1.1.6 from 1.1.5: > Merge pull request adafruit/Adafruit_CircuitPython_EMC2101#13 from dhalbert/setup-packages Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Text to 2.18.1 from 2.17.0: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#147 from jposada202020/api_example > Merge pull request adafruit/Adafruit_CircuitPython_Display_Text#145 from jposada202020/master > "Increase duplicate code check threshold "
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants