Skip to content

Conversation

@RetiredWizard
Copy link
Contributor

@RetiredWizard RetiredWizard commented Nov 6, 2023

I don't know if this approach to the displayio changes helps, but I figured I post this as an example.

fixes #17

@dhalbert
Copy link
Contributor

dhalbert commented Nov 6, 2023

How about

try: from fourwire import FourWire except ImportError: from displayio import FourWire

Then user FourWire by itself in the code.
I think that is more compact.
also could use some import as... to accomodate name changes like BusDisplay.

@RetiredWizard
Copy link
Contributor Author

Yeah, that's closer to what I did for the driver itself. I'll update the example that way as well 😁

Copy link
Contributor

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. This display is a bit complicated in what it can do!

@dhalbert dhalbert merged commit 107baf3 into adafruit:main Nov 6, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Nov 7, 2023
Updating https://github.com/adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305 to 1.4.0 from 1.3.12: > Merge pull request adafruit/Adafruit_CircuitPython_DisplayIO_SSD1305#18 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_FocalTouch to 1.5.0 from 1.4.11: > Merge pull request adafruit/Adafruit_CircuitPython_FocalTouch#31 from Fexiven/main Updating https://github.com/adafruit/Adafruit_CircuitPython_SSD1675 to 1.3.0 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_SSD1675#18 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_ST7789 to 1.6.0 from 1.5.18: > Merge pull request adafruit/Adafruit_CircuitPython_ST7789#37 from RetiredWizard/main Updating https://github.com/adafruit/Adafruit_CircuitPython_HTTPServer to 4.4.4 from 4.4.3: > Merge pull request adafruit/Adafruit_CircuitPython_HTTPServer#72 from michalpokusa/template-example Updating https://github.com/adafruit/Adafruit_CircuitPython_Qualia to 1.0.1 from 1.0.0: > Fix Display ID in paint example Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_Qualia Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants