remove unused block containing deprecated imp module #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
TheKitty approved these changes Jan 22, 2025
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 28, 2025
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 3.1.14 from 3.1.13: > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#48 from FoamyGuy/fix_docs_build Updating https://github.com/adafruit/Adafruit_CircuitPython_CCS811 to 1.3.19 from 1.3.18: > Merge pull request adafruit/Adafruit_CircuitPython_CCS811#53 from FoamyGuy/remove_imp_usage Updating https://github.com/adafruit/Adafruit_CircuitPython_MCP2515 to 1.1.8 from 1.1.7: > Merge pull request adafruit/Adafruit_CircuitPython_MCP2515#28 from SamantazFox/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_PIOASM to 1.3.2 from 1.3.1: > Merge pull request adafruit/Adafruit_CircuitPython_PIOASM#76 from adafruit/fix-print-c-program
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
After finding adafruit/Adafruit_CircuitPython_APDS9960#47 I have searched the bundle for instances of
import impand found that this library is the only other library in the bundle that has one albeit in a block of commented out code so it's not actually breaking the docs build for this repo.This pr removes the commented block.