Check nina-fw version in code #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
This was referenced Oct 21, 2019
ladyada approved these changes Oct 21, 2019
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Oct 21, 2019
Updating https://github.com/adafruit/Adafruit_CircuitPython_AWS_IOT to 1.1.0 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#4 from brentru/version-check-code > Merge pull request adafruit/Adafruit_CircuitPython_AWS_IOT#3 from adafruit/dherrada-patch-1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This library requires nina-fw version 1.4.0 or above. Instead of checking the MiniMQTT's wifi client attribute, check the nina-fw version from within the code.
Notes:
set_certificateandset_private_keycheck within library, example code calls these two methods.