Deinit fix #5
Deinit fix #5
Conversation
| Thanks for making this PR @chrisgilldc the actions checks failed due to code formatting. We have a guide that covers the process that we use for all of the code: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code The page I linked contains instructions for the "all-in-one" tool pre-commit which essentially runs all of the checks at once. The following few pages in the guide explain each check individually if you're interested in the different ones (though the all-in-one option should be all you need to get this passing the checks.) |
| @chrisgilldc are you still interested in working on this PR? If so we need to get it passing the CI checks, if you need help with that let us know here or reach out on the Discord. |
| I am at some point, but have not had the cycles to dig in. I think I'd definitely need assistance to get it to pass CI. If it's better to close this and then re-open later, that's entirely cool. …On Mon, Jan 24, 2022, at 9:45 AM, foamyguy wrote: @chrisgilldc <https://github.com/chrisgilldc> are you still interested in working on this PR? If so we need to get it passing the CI checks, if you need help with that let us know here or reach out on the Discord. — Reply to this email directly, view it on GitHub <#5 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAPLLW2X4GXIGVY3VUJ4UCTUXVQ2HANCNFSM5ITIGBHQ>. You are receiving this because you were mentioned.Message ID: ***@***.***> |
| Okay sounds good. I'll close it for now. Feel free to re-open any time. Also feel free to ping me here, or reach out in the discord. There are many folks around there who can help with the CI process. |
3 participants
Adds a deinit method to the DigitalInOut object created by AW9523. Tested and seems to now allow AW9523 DigitalInOut objects to be used as a drop-in for digitalio.DigitalInOut objects. That said, not a python expert and this is my first public pull request, so likely needs a second set of eyes.