Fix errors with invalid csv #200
Merged
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
We have 2 situation when raised errors without handling:
In this case encoding detected automatically by
But if data is empty string '' result will be nil.
data.force_encoding(encoding_name)wheredata is empty string and encoding_name is nilraise TypeError: no implicit conversion of nil into StringWe can handle it in collection_action and return flash message to users