Skip to content

Add ActiveAdminImport::Exception #175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Fivell merged 1 commit into from
Feb 5, 2020
Merged

Add ActiveAdminImport::Exception #175

Fivell merged 1 commit into from
Feb 5, 2020

Conversation

@linqueta
Copy link
Contributor

@linqueta linqueta commented Jan 30, 2020

How was discussed in the issue #174 , this exception will let who consumes the gem create a custom error to threat it as a failure in import.
@coveralls
Copy link

coveralls commented Jan 30, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.05%) to 97.826% when pulling e4e23c9 on linqueta:add-active-admin-import-exception into ff3a6e9 on activeadmin-plugins:master.
@linqueta linqueta changed the title [WIP] Add active admin import exception Add active admin import exception Jan 30, 2020
@linqueta linqueta force-pushed the add-active-admin-import-exception branch from b8ceb3b to 8833dd3 Compare January 30, 2020 18:31
@linqueta
Copy link
Contributor Author

linqueta commented Jan 30, 2020 •
edited
Loading

Is happening this error for Rails version 5.2.2.1:

Failure/Error: require 'active_admin' NameError: uninitialized constant Responders::FlashResponder::ActionView Did you mean? ActionDispatch

Do I have to do something?
@linqueta linqueta changed the title Add active admin import exception Add ActiveAdminImport::Exception Jan 30, 2020
@Fivell
Copy link
Member

Fivell commented Jan 31, 2020

@linqueta hard to say, will take a look next week
@linqueta
Copy link
Contributor Author

linqueta commented Jan 31, 2020

@linqueta hard to say, will take a look next week

I'll look too on this weekend.
@linqueta
Copy link
Contributor Author

linqueta commented Feb 1, 2020

@linqueta hard to say, will take a look next week

Hey @Fivell , I fixed the problem in #176 , it was simple, just requiring 'action_view'. If you approve, I'll rebase it.
@Fivell Fivell self-assigned this Feb 3, 2020
Fivell
Fivell requested changes Feb 3, 2020
View reviewed changes
@linqueta linqueta requested a review from Fivell February 4, 2020 13:02
@Fivell
Copy link
Member

Fivell commented Feb 4, 2020

@linqueta good please squash commits and lets merge/release
@linqueta linqueta force-pushed the add-active-admin-import-exception branch 6 times, most recently from 267b7d9 to db00834 Compare February 5, 2020 13:01
@linqueta
add active admin import exception
e4e23c9 
handle exception when import a file fix uninitialized constant Responders::FlashResponder::ActionView use file_error instead no_file_error fix uninitialized constant Responders::FlashResponder::ActionView fix uninitialized constant Responders::FlashResponder::ActionView
@linqueta linqueta force-pushed the add-active-admin-import-exception branch from db00834 to e4e23c9 Compare February 5, 2020 13:04
@Fivell Fivell merged commit 0a1c06d into activeadmin-plugins:master Feb 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@linqueta @coveralls @Fivell