Allow activerecord-import >= 0.27 #171
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Fivell approved these changes Dec 16, 2019
Fivell added a commit that referenced this pull request Dec 16, 2019
…-import-version-unlocked Allow activerecord-import >= 0.27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
This fork repo is made so that we can use this Active Admin import gem but without the activerecord-import version restriction.
We are actually using activerecord-import > 1.0.0 in our project but in their project they decided that the dependency of activerecord-import gem must be a fixed older version (2018).
The reason for this fixed dependency was some kind of corner cases with uniqueness validations failing on certain occasions.