Upgrade to activerecord-import 0.27.0 #161
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
houndci-bot reviewed Oct 9, 2018
lib/active_admin_import/importer.rb Outdated
| | ||
| def assign_options(options) | ||
| @options = { batch_size: 1000, validate: true }.merge(options.slice(*OPTIONS)) | ||
| @options = { batch_size: 1000, validate: true, validate_uniqueness: true }.merge(options.slice(*OPTIONS)) |
There was a problem hiding this comment.
Metrics/LineLength: Line is too long. [111/80]
Contributor Author
| Hi @Fivell, any chance you could take a look at this PR for me? |
Member
| @jkowens looks good, looks like we can update now without regression 👍 |
Fivell approved these changes Jan 11, 2019
Member
| @workgena take a look pls, if ok lets release new version |
This was referenced Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
An option to enable uniqueness validators was added to activerecord-import v0.27.0. There are several pitfalls with attempting uniqueness validation, so it is still not recommended. See zdennis/activerecord-import#228 for more info.
Closes #151, #152, #160.