Refactor Gitimporter using fetchcode #817
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
ziadhany force-pushed the git-fetchcode branch from ec88205 to 7ca35b3 Compare 
| @ziadhany , please add logs for gitlab importer. |
TG1999 requested changes Sep 22, 2022
|
TG1999 reviewed Sep 27, 2022
vulnerabilities/importers/gitlab.py Outdated
| | ||
| | ||
| class GitLabAPIImporter(Importer): | ||
| class GitLabGitImporter(GitImporter): |
There was a problem hiding this comment.
@ziadhany this will change the qualified name for importer and the databases will still have the old qualified name stored in them, which will now not be recogonised by improver, either write a migration to support this change or do not change the name of importer.
| Please rebase with the latest main |
pombredanne reviewed Oct 10, 2022
| TEST_DATA = os.path.join(BASE_DIR, "test_data/") | ||
| | ||
| | ||
| def load_oval_data(): |
There was a problem hiding this comment.
IMHO this would be best moved to a new test_oval.py
| assert os.path.join(self.repodir, "crates/hyper/RUSTSEC-2020-0008.toml") in updated_files | ||
| | ||
| | ||
| class TestOvalImporter(TestCase): |
There was a problem hiding this comment.
IMHO this would be best moved to a new test_oval.py and not just deleted
There was a problem hiding this comment.
I cannot approve this if we just delete all these tests above.
There was a problem hiding this comment.
I have secured oval importer tests in the file itself https://github.com/nexB/vulnerablecode/pull/817/files#diff-eb1cffdadef3eacc470900468af6cce0bdd6ae476bc9ae94ce512863c060f850R40, and just deleted the GitImporter tests that are not related with the latest importers.
| def test_clone_valid(self): | ||
| with patch.object(GitImporter, "__init__", return_value=None): | ||
| c = GitImporter(None) | ||
| c.repo_url = "git+https://github.com/nexB/fetchcode" |
There was a problem hiding this comment.
Does this do a live clone over the network?
There was a problem hiding this comment.
yes, it clones the repository
( I just mock a constructor and then make the Git importer run, so I can test the result )
TG1999 force-pushed the git-fetchcode branch 5 times, most recently from e4ad48a to b8c4b6f Compare 
Co-authored-by: Tushar Goel <tushar.goel.dav@gmail.com> Signed-off-by: ziadhany <ziadhany2016@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Reference: #806
Signed-off-by: ziad ziadhany2016@gmail.com