Cleanup requirement string to avoid packvers parsing issues #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
MarcelBochtler force-pushed the requirements-hashes branch 14 times, most recently from b97c3b9 to d158eb0 Compare 
| @MarcelBochtler In commit message you state "Remove the |
MarcelBochtler force-pushed the requirements-hashes branch from d158eb0 to e32d180 Compare 
@tsteenbe Opened the issue and linked it in the commit message. |
MarcelBochtler force-pushed the requirements-hashes branch 8 times, most recently from efc9b27 to 50d7cc8 Compare 
Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
MarcelBochtler force-pushed the requirements-hashes branch from 50d7cc8 to b8d4cae Compare The compatibility check is already ignoring the `hash_options` [1], while a `Requirement` is still constructed in [2] and [3]. This causes the application to crash and fail to create a result. Remove the `hash_options` for now until `packvers.requirements.Requirement` supports this option [4]. [1]: https://github.com/aboutcode-org/python-inspector/blob/3ad3925840e8dad16ad12b3917f04ec3172590ad/src/_packagedcode/pypi.py#L999 [2]: https://github.com/aboutcode-org/python-inspector/blob/3ad3925840e8dad16ad12b3917f04ec3172590ad/src/python_inspector/api.py#L484 [3]: https://github.com/aboutcode-org/python-inspector/blob/3ad3925840e8dad16ad12b3917f04ec3172590ad/src/python_inspector/resolution.py#L259 [4]: aboutcode-org/packvers#4 Resolves aboutcode-org#243. Signed-off-by: Marcel Bochtler <marcel.bochtler@bosch.com>
MarcelBochtler force-pushed the requirements-hashes branch from b8d4cae to 1675126 Compare 
AyanSinhaMahapatra approved these changes Sep 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
See commit messages for details.