Skip to content

Conversation

ukaj
Copy link

@ukaj ukaj commented Mar 11, 2025

Before this change, the index_urls variable contained incorrectly parsed values:

('https://pypi.org/simple', 'h', 't', 't', 'p', 's', ':', '/', '/', 'p', 'y', 'p', 'i', '.', 'o', 'r', 'g', '/', 's', 'i', 'm', 'p', 'l', 'e') 

After this fix, index_urls is parsed as:

('https://pypi.org/simple', 'https://pypi.org/simple') 

Fixes #173

@sschuberth
Copy link
Contributor

@ukaj as tests in CI should be fixed now, can you please rebase your PR?

@pombredanne
Copy link
Member

@ukaj do you mind to add a test too? And is the issue coming from the pip-requirements-parser library?

@sschuberth
Copy link
Contributor

@ukaj as tests in CI should be fixed now, can you please rebase your PR?

@heliocastro, could you take care of this?

Signed-off-by: ukaj <ukaj869@gmail.com>
@ukaj ukaj force-pushed the fix/unsupported_url_scheme branch from 48882b0 to a89fcee Compare April 17, 2025 08:58
@sschuberth
Copy link
Contributor

Thanks @ukaj for the update. Now @pombredanne or @TG1999, can you please approve the workflow?

@kerstin-bosch
Copy link

Hi, @pombredanne and @TG1999 from Bosch side we would also be very interested in a solution, as we currently have several customers who are affected. It would be amazing if you approve the workflow. Thank you very much!

@TG1999
Copy link
Contributor

TG1999 commented Apr 17, 2025

@kerstin-bosch @sschuberth workflow has been approved but tests are failing. I am looking into how can I fix the failing tests here.

@kerstin-bosch
Copy link

Hi @TG1999, did you have a chance to look at the tests already? Thanks in advance!

TG1999 added 2 commits April 29, 2025 13:30
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Copy link
Contributor

TG1999 commented Apr 29, 2025

@kerstin-bosch I have updated the tests, I have also added the missing test for this PR which caused some delay. Merging this soon! Thanks for your patience.

@TG1999 TG1999 merged commit e7baa00 into aboutcode-org:main Apr 29, 2025
6 of 9 checks passed
@kerstin-bosch
Copy link

@TG1999: That's really great, thank you very much! :) Are you planning a release soon?

@pombredanne
Copy link
Member

@kerstin-bosch re:

Are you planning a release soon?

Yes, we have a few pending nasty bugs introduced by asyncio that I work out since last week and ETA for a new release is today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

5 participants