Skip to content

Conversation

tdruez
Copy link
Contributor

@tdruez tdruez commented Mar 28, 2024

No description provided.

@tdruez tdruez requested a review from TG1999 March 28, 2024 07:11
Signed-off-by: tdruez <tdruez@nexb.com>
Copy link
Contributor

@TG1999 TG1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can have a test in 'test_resolution.py' to validate if our resolutions can take python version 3.12 as a valid input and do the resolutions

TG1999 added 3 commits March 28, 2024 13:18
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999
Copy link
Contributor

TG1999 commented Mar 28, 2024

I am merging this, there is likely a black heisenbug that only is in python 3.12, I am not able to recreate this bug locally with 3.12.

Signed-off-by: Tushar Goel <tushar.goel.dav@gmail.com>
@TG1999 TG1999 merged commit b4fa534 into main Mar 28, 2024
@pombredanne pombredanne deleted the python3.12 branch April 1, 2025 17:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants