Skip to content

Conversation

@eboadom
Copy link
Collaborator

@eboadom eboadom commented Jan 28, 2021

Closes #12

@eboadom
Copy link
Collaborator Author

eboadom commented Jan 28, 2021

What was done in the smart contracts on 80fd095:

  • On LendingPool, just changed the immutables to storage variables appended at the end of LendingPoolStorage.
  • On AToken, VariableDebtToken and StableDebtToken, changed the immutables to storage variables appended at the end of each of the contracts' layouts. In the case of the _incentivesController immutable on IncentivizedERC20, it needed to be moved to the children aToken/debtTokens, to not break compatibility with previous storage layouts. This obliged to change the IncentivedERC20 to abstract, with some abstract functions. Also on aToken/debtTokens, the explicit constructors are not needed anymore, and the initialize() functions receive extra parameters.
  • LendingPoolConfigurator has been adapted to support the previous changes and now it only allows to initialized reserves in batch.
  • Additional helpers, not part of the protocol and used mainly for simpler deployment procedure have been modified accordingly to the changes mainly on LendingPoolConfigurator

P.D. Tests and deployments have not been adapted yet

Zer0dot and others added 26 commits February 23, 2021 10:59
Updated a few small errors & changed "Lp" to "Amm"
Config updated to reflect new networks.
@The-3D The-3D marked this pull request as ready for review March 5, 2021 09:43
Copy link
Collaborator

@The-3D The-3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This merge request contains a refactoring to enable lighter deployments of different markets and configuration for various sidechains/L2s. It has been extensively reviewed

@The-3D The-3D merged commit 7e39178 into master Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

7 participants