- Notifications
You must be signed in to change notification settings - Fork 455
fix: fix repay with collateral #770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| @defispartan there still seems to be an issue - which weirdly i can only reproduce on ethereum where the flashAmount for some reason is smaller then then maxAmountToPay (reproducible via tenderly). No idea where it's coming from exactly. |
|
📦 Next.js Bundle AnalysisThis analysis was generated by the next.js bundle analysis action 🤖 |
| Page | Size (compressed) |
|---|---|
global | 484.68 KB (🟡 +72 B) |
Details
The global bundle is the javascript bundle that loads alongside every page. It is in its own category because its impact is much higher - an increase to its size means that every page on your website loads slower, and a decrease means every page loads faster.
Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis
If you want further insight into what is behind the changes, give @next/bundle-analyzer a try!
| I think the same logic is needed for price impact as well. One thing I didn't know until researching further is that price impact and slippage are not the same thing: https://doc.paraswap.network/price-impact-slippage. When you test a swap with high slippage, you can see that the expected input amount is calculated before price impact is taken into account: |
| Im able to replicate errors on a position with LINK as collateral, unable to repay USDT or DAI |
| Just Error getting txParams |
| There is one case where "Error getting txParams" is visible - it happens when a user wants to swap ETH -> to any other assets. Here are the reproduction steps: This API POST Request throws error 500 - https://api.paraswap.io/transactions/1/?ignoreChecks=true
|
| is this also related to this issue #786 ? |
| Looks to me to be the same error |
|
|
| Thanks @defispartan for investigating and running this down |
Resolves some issues with the current repay with collateral implementation: