Skip to content

Conversation

rafaelss95
Copy link

@rafaelss95 rafaelss95 commented Jan 29, 2017

@rafaelss95 rafaelss95 changed the title feat(underscore): Add new filter - 'UnderscoreFilter' feat: Add new filters - String case filters Jan 29, 2017
@rafaelss95
Copy link
Author

@a8m Will you merge this?

README.md Outdated
```html
<p>{{ 'a_simple_word' | camelize }}</p>
<p>{{ 'ANUPPERCASEDWORD' | camelize }}</p>
<p>{{ 'angular-js' | camelize: true }}</p>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe also mention what happens to a sentence -> aSentence

README.md Outdated
###camelize

Converts a string to camelCase<br/>
usage: ```string | camelize: [upperFirst:boolean|optional]```<br/>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The camelCase filter with upperFirst enabled is basically a PascalCase filter. Maybe it's better to split them up into two filters.

-->
```

###camelize

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not call it camelCase?


<!--
result:
aSimpleWord

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

anuppercaseword is missing

@rafaelss95
Copy link
Author

@SteveVanOpstal, please check it now. I've made some changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants