Skip to content

Conversation

@sokoliva
Copy link
Contributor

@sokoliva sokoliva commented Nov 14, 2025

This commit adds a constructor boolean variable disable_content_length_check to the base class JSONRPCApplication and its derived classes A2AFastAPIApplication and A2AStarletteApplication. In JSONRPCApplication's method _handle_requests it adds a if disable_content_length_check check before checking if the payload exceeds the MAX_CONTENT_LENGTH limit.

This enables agent creators to disable the 10MB payload size limitation.

BEGIN_COMMIT_OVERRIDE
feat(jsonrpc): add option to disable oversized payload check in JSONRPC applications

Release-As: 0.3.14
END_COMMIT_OVERRIDE

@sokoliva sokoliva requested a review from a team as a code owner November 14, 2025 15:47
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @sokoliva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new configuration option across the JSON-RPC application stack, allowing developers to selectively disable the default payload size validation. This enhancement provides greater flexibility for applications that need to handle larger data volumes, ensuring that the system can adapt to diverse operational requirements without encountering premature payload size errors.

Highlights

  • New Configuration Option: Introduced a new boolean constructor variable, disable_content_length_check, to the JSONRPCApplication base class and its derived classes (A2AFastAPIApplication, A2AStarletteApplication).
  • Payload Size Limit Control: The existing 10MB payload size limitation check within the _handle_requests method is now conditional, allowing it to be bypassed if disable_content_length_check is set to True.
  • Enhanced Flexibility: This change provides agent creators with the ability to disable the default payload size restriction, accommodating use cases that require larger JSON-RPC requests.
  • New Test Case: A new test test_handle_oversized_payload_with_check_disabled has been added to verify that oversized payloads are correctly processed when the content length check is disabled.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@sokoliva sokoliva requested a review from lkawka November 14, 2025 15:48
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a disable_content_length_check option to the JSON-RPC application classes, allowing developers to bypass the default 10MB payload size limit. The implementation is correct and includes a new test case to validate the functionality. The changes are well-scoped and effectively address the feature request. I've included a couple of minor suggestions to fix typos in comments and documentation for consistency.

@sokoliva sokoliva enabled auto-merge (squash) November 14, 2025 15:58
@sokoliva sokoliva self-assigned this Nov 17, 2025
…ardcoded MAX_CONTENT_LENGTH and introduces an instance variable max_content_length.
@sokoliva sokoliva merged commit ba142df into a2aproject:main Nov 17, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants