- Notifications
You must be signed in to change notification settings - Fork 283
feat(jsonrpc): add option to disable oversized payload check in JSONRPC applications #544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @sokoliva, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a new configuration option across the JSON-RPC application stack, allowing developers to selectively disable the default payload size validation. This enhancement provides greater flexibility for applications that need to handle larger data volumes, ensuring that the system can adapt to diverse operational requirements without encountering premature payload size errors. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a disable_content_length_check option to the JSON-RPC application classes, allowing developers to bypass the default 10MB payload size limit. The implementation is correct and includes a new test case to validate the functionality. The changes are well-scoped and effectively address the feature request. I've included a couple of minor suggestions to fix typos in comments and documentation for consistency.
…ardcoded MAX_CONTENT_LENGTH and introduces an instance variable max_content_length.
This commit adds a constructor boolean variable disable_content_length_check to the base class JSONRPCApplication and its derived classes A2AFastAPIApplication and A2AStarletteApplication. In JSONRPCApplication's method _handle_requests it adds a if disable_content_length_check check before checking if the payload exceeds the MAX_CONTENT_LENGTH limit.
This enables agent creators to disable the 10MB payload size limitation.
BEGIN_COMMIT_OVERRIDE
feat(jsonrpc): add option to disable oversized payload check in JSONRPC applications
Release-As: 0.3.14
END_COMMIT_OVERRIDE