Skip to content

Conversation

@mikeas1
Copy link
Contributor

@mikeas1 mikeas1 commented Oct 15, 2025

Description

This PR adds a convenience method for constructing a Client from either an AgentCard URL or an AgentCard directly. The goal is to reduce the number of lines of code required for simple client creation, but still enabling more advanced handled of client construction.

Usage example:

my_agent_url = 'https://travel-agent.example.com' client = await ClientFactory.connect(my_agent_url) await client.send_message(...)

BEGIN_COMMIT_OVERRIDE
feat: Add a ClientFactory.connect() method for easy client creation
Release-As: 0.3.10
END_COMMIT_OVERRIDE

@mikeas1 mikeas1 requested a review from a team as a code owner October 15, 2025 17:53
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @mikeas1, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the ClientFactory by adding a convenient connect class method. This method streamlines the process of creating client instances, allowing developers to quickly establish connections to agents by simply providing a URL or an AgentCard, thereby reducing boilerplate code and improving ease of use for common client setup patterns.

Highlights

  • New ClientFactory.connect method: Introduced a new asynchronous class method connect to the ClientFactory for simplified client creation.
  • Flexible Client Initialization: The connect method can now accept either an AgentCard URL (which it resolves internally) or a pre-existing AgentCard object.
  • Configuration Options: The new connect method supports various client configuration parameters, including ClientConfig, consumers, interceptors, relative_card_path, resolver_http_kwargs, and extra_transports.
  • Comprehensive Testing: Added extensive unit tests to cover various scenarios for the connect method, ensuring its robustness with different input types and configurations.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@holtskinner holtskinner changed the title feat: Add a ClientFactory.connect method for easy client creation feat: Add a ClientFactory.connect() method for easy client creation Oct 15, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a convenient ClientFactory.connect method for easier client creation. The implementation is mostly solid and well-tested. However, I've found a bug where some parameters are ignored when an httpx_client is not provided, leading to inconsistent behavior. I've suggested a fix that also refactors the code for better readability and maintainability. I've also noted a test that will need to be updated along with the fix.

@holtskinner holtskinner merged commit d585635 into a2aproject:main Oct 16, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants