Skip to content

Conversation

@Lancetnik
Copy link
Contributor

MacOS doesn't support commands like pip install package[extra] without escaping. Other installation commands are written like pip install "a2a-sdk[extra]", for this reason. I have just fixed this issue.

MacOS doesn't support commands like `pip install package[extra]` without escaping. Other installation commands are written like `pip install "a2a-sdk[extra]"`, for this reason. I have just fixed this issue.
@Lancetnik Lancetnik requested a review from a team as a code owner October 1, 2025 07:48
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Lancetnik, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a minor but important documentation issue in the README.md related to the installation of the a2a-sdk with all its extras. The change ensures that the provided uv add and pip install commands are correctly formatted with quotes around the [all] extra, resolving compatibility problems on operating systems like macOS where unescaped brackets can lead to command execution errors. This improves the user experience by providing universally functional installation instructions.

Highlights

  • Documentation Update: Corrected the installation commands for a2a-sdk[all] in the README.md to properly quote the extra dependency group.
  • Cross-Platform Compatibility: Ensured that the uv add and pip install commands for the 'all' extras are compatible with macOS and other systems that require escaping for bracketed expressions in shell commands.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes an issue in the README.md where installation commands with extras were not quoted, which can cause issues in some shells. By adding quotes to the a2a-sdk[all] installation commands for both pip and uv, you've improved the documentation's clarity and reliability for all users. This change also makes the command consistent with other extras in the table. The change is well-executed and I have no further suggestions.

Copy link
Member

@holtskinner holtskinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix

@holtskinner holtskinner changed the title docs: a2a-sdk[all] installation command in Readme docs: a2a-sdk[all] installation command in Readme Oct 1, 2025
@holtskinner holtskinner enabled auto-merge (squash) October 1, 2025 14:45
@holtskinner holtskinner disabled auto-merge October 1, 2025 14:46
@holtskinner holtskinner merged commit 6ac9a7c into a2aproject:main Oct 1, 2025
6 checks passed
holtskinner pushed a commit that referenced this pull request Oct 6, 2025
🤖 I have created a release *beep* *boop* --- ## [0.3.8](v0.3.7...v0.3.8) (2025-10-06) ### Bug Fixes * Add `__str__` and `__repr__` methods to `ServerError` ([#489](#489)) ([2c152c0](2c152c0)) * **grpc:** Fix missing extensions from protobuf ([#476](#476)) ([8dbc78a](8dbc78a)) * **rest:** send `historyLength=0` (avoid falsy omission) ([#480](#480)) ([ed28b59](ed28b59)), closes [#479](#479) ### Documentation * `a2a-sdk[all]` installation command in Readme ([#485](#485)) ([6ac9a7c](6ac9a7c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants