- Notifications
You must be signed in to change notification settings - Fork 283
docs: a2a-sdk[all] installation command in Readme #485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
MacOS doesn't support commands like `pip install package[extra]` without escaping. Other installation commands are written like `pip install "a2a-sdk[extra]"`, for this reason. I have just fixed this issue.
Summary of ChangesHello @Lancetnik, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a minor but important documentation issue in the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly fixes an issue in the README.md where installation commands with extras were not quoted, which can cause issues in some shells. By adding quotes to the a2a-sdk[all] installation commands for both pip and uv, you've improved the documentation's clarity and reliability for all users. This change also makes the command consistent with other extras in the table. The change is well-executed and I have no further suggestions.
holtskinner left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fix
a2a-sdk[all] installation command in Readme 🤖 I have created a release *beep* *boop* --- ## [0.3.8](v0.3.7...v0.3.8) (2025-10-06) ### Bug Fixes * Add `__str__` and `__repr__` methods to `ServerError` ([#489](#489)) ([2c152c0](2c152c0)) * **grpc:** Fix missing extensions from protobuf ([#476](#476)) ([8dbc78a](8dbc78a)) * **rest:** send `historyLength=0` (avoid falsy omission) ([#480](#480)) ([ed28b59](ed28b59)), closes [#479](#479) ### Documentation * `a2a-sdk[all]` installation command in Readme ([#485](#485)) ([6ac9a7c](6ac9a7c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
MacOS doesn't support commands like
pip install package[extra]without escaping. Other installation commands are written likepip install "a2a-sdk[extra]", for this reason. I have just fixed this issue.