[ImgBot] Optimize images #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
*Total -- 2,056.39kb -> 1,587.14kb (22.82%) /src/libraries/System.Reflection/tests/Resources/EmbeddedImage.png -- 9.92kb -> 0.59kb (94.01%) /docs/project/portability_screenshot.png -- 42.77kb -> 18.01kb (57.89%) /docs/design/coreclr/botr/images/dac-overview.png -- 8.75kb -> 3.83kb (56.18%) /src/libraries/System.Diagnostics.Tracing/documentation/PerfViewCapture_Counters.png -- 105.59kb -> 51.21kb (51.51%) /src/libraries/System.Diagnostics.Tracing/documentation/PerfViewCapture_Events.png -- 110.61kb -> 53.80kb (51.36%) /docs/design/features/code-versioning-ideal-tree.png -- 14.34kb -> 7.10kb (50.46%) /docs/design/coreclr/botr/images/type-system-dependencies.png -- 27.95kb -> 13.90kb (50.26%) /docs/design/features/code-versioning-ideal-tree-active.png -- 15.28kb -> 7.67kb (49.82%) /docs/design/coreclr/botr/images/methoddesc-fig1.png -- 22.51kb -> 11.75kb (47.81%) /docs/design/features/code-versioning-ideal-tree-update.png -- 16.24kb -> 8.50kb (47.65%) /docs/design/coreclr/botr/images/virtualstubdispatch-fig2.png -- 10.45kb -> 5.74kb (45.04%) /docs/design/coreclr/botr/images/methoddesc-fig2.png -- 18.30kb -> 10.06kb (45.03%) /docs/design/coreclr/botr/images/methoddesc-fig3.png -- 16.55kb -> 9.23kb (44.24%) /docs/design/features/unloadability.svg -- 20.92kb -> 11.69kb (44.12%) /docs/design/coreclr/botr/images/ryujit-high-level-overview.png -- 25.65kb -> 14.80kb (42.29%) /docs/design/coreclr/botr/images/typeloader-fig3.png -- 14.68kb -> 8.61kb (41.36%) /docs/design/coreclr/botr/images/typeloader-fig1.png -- 16.54kb -> 9.94kb (39.94%) /docs/design/coreclr/botr/images/virtualstubdispatch-fig1.png -- 20.60kb -> 12.57kb (38.95%) /docs/design/coreclr/botr/images/typeloader-fig4.png -- 16.89kb -> 10.36kb (38.65%) /docs/project/api-review-process.png -- 81.28kb -> 50.63kb (37.71%) /docs/design/coreclr/botr/images/ryujit-initial-phases.png -- 12.01kb -> 7.76kb (35.44%) /docs/design/coreclr/botr/images/virtualstubdispatch-fig4.png -- 8.12kb -> 5.31kb (34.65%) /docs/design/coreclr/botr/images/virtualstubdispatch-fig3.png -- 9.61kb -> 6.41kb (33.31%) /docs/project/portability_solution_explorer.png -- 79.29kb -> 53.50kb (32.53%) /docs/design/coreclr/botr/images/typeloader-fig2.png -- 6.93kb -> 4.68kb (32.37%) /docs/workflow/profiling/davbr-blog-archive/media/Attach.jpg -- 41.60kb -> 31.12kb (25.2%) /docs/design/coreclr/botr/images/profiling-gc.png -- 32.19kb -> 25.54kb (20.64%) /docs/workflow/profiling/davbr-blog-archive/media/4276.image1_31CAADB7.png -- 55.62kb -> 44.28kb (20.38%) /docs/workflow/profiling/davbr-blog-archive/media/8715.image1_thumb_38118445.png -- 40.05kb -> 32.85kb (17.98%) /src/installer/pkg/packaging/osx/sharedframework/resources/dotnetbackground.png -- 4.49kb -> 3.71kb (17.34%) /src/installer/pkg/packaging/osx/hostfxr/resources/dotnetbackground.png -- 4.49kb -> 3.71kb (17.34%) /src/installer/pkg/packaging/version_badge.svg -- 0.69kb -> 0.59kb (15.25%) /docs/design/coreclr/botr/images/ryujit-backend-phases.png -- 6.91kb -> 5.97kb (13.51%) /docs/workflow/profiling/davbr-blog-archive/media/2110.image_051F632D.png -- 54.27kb -> 47.39kb (12.68%) /docs/design/coreclr/botr/images/ryujit-flowgraph.png -- 18.82kb -> 16.44kb (12.65%) /docs/project/portability_report.png -- 163.70kb -> 143.49kb (12.35%) /docs/workflow/profiling/davbr-blog-archive/media/8715.image_thumb_01A0D243.png -- 38.29kb -> 33.69kb (12.02%) /src/libraries/System.Diagnostics.Tracing/documentation/PerfViewCapture_Menu.png -- 71.56kb -> 62.99kb (11.98%) /docs/workflow/profiling/davbr-blog-archive/media/deadlock.jpg -- 40.51kb -> 36.18kb (10.7%) /docs/workflow/profiling/davbr-blog-archive/media/gccycle.jpg -- 37.51kb -> 33.60kb (10.41%) /docs/design/coreclr/botr/images/stack.png -- 88.19kb -> 79.07kb (10.33%) /docs/design/coreclr/botr/images/ryujit-phase-diagram.png -- 23.67kb -> 21.41kb (9.55%) /docs/design/coreclr/botr/images/ryujit-ir-overview.png -- 25.22kb -> 23.04kb (8.63%) /docs/design/coreclr/botr/images/profiling-overview.png -- 70.08kb -> 64.90kb (7.39%) /docs/design/coreclr/botr/images/ryujit-ir-ordered.png -- 33.29kb -> 30.87kb (7.25%) /docs/design/coreclr/botr/images/ryujit-lir.png -- 27.80kb -> 25.99kb (6.52%) /docs/design/coreclr/botr/images/ryujit-optimization-phases.png -- 5.44kb -> 5.09kb (6.48%) /docs/design/coreclr/botr/images/profiling-exception-callback-sequence.png -- 228.94kb -> 215.57kb (5.84%) /docs/design/features/GreenNode_WriteTo_CallGraph.png -- 147.85kb -> 139.90kb (5.38%) /src/libraries/System.Diagnostics.Tracing/documentation/PerfViewCapture_Plot.png -- 28.67kb -> 27.69kb (3.41%) /docs/project/pcl-targets-dialog-net46-aspnetcore10.png -- 34.78kb -> 34.42kb (1.02%) Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
trylek pushed a commit that referenced this pull request Feb 13, 2020
…otnet#2073) `jit_tls->interp_context` gets initialized lazily, that is, upon the first interpreter execution on a specific thread (e.g. via interp_runtime_invoke). However, with mixed mode the execution can purely happen in AOT code upon the first interaction with the managed debugger. Stack trace: ``` thread #1, name = 'tid_407', queue = 'com.apple.main-thread' frame #0: 0x0000000190aedc94 libsystem_kernel.dylib`__psynch_cvwait + 8 frame #1: 0x0000000190a0f094 libsystem_pthread.dylib`_pthread_cond_wait$VARIANT$armv81 + 672 frame #2: 0x000000010431318c reloadcontext.iOS`mono_os_cond_wait(cond=0x0000000104b9ba78, mutex=0x0000000104b9ba30) at mono-os-mutex.h:219:8 frame #3: 0x0000000104312a68 reloadcontext.iOS`mono_coop_cond_wait(cond=0x0000000104b9ba78, mutex=0x0000000104b9ba30) at mono-coop-mutex.h:91:2 frame #4: 0x0000000104312858 reloadcontext.iOS`suspend_current at debugger-agent.c:3021:4 frame #5: 0x000000010431be18 reloadcontext.iOS`process_event(event=EVENT_KIND_BREAKPOINT, arg=0x0000000145d09ae8, il_offset=0, ctx=0x0000000149015c20, events=0x0000000000000000, suspend_policy=2) at debugger-agent.c:4058:3 frame #6: 0x0000000104310cf4 reloadcontext.iOS`process_breakpoint_events(_evts=0x000000028351a680, method=0x0000000145d09ae8, ctx=0x0000000149015c20, il_offset=0) at debugger-agent.c:4722:3 frame #7: 0x000000010432f1c8 reloadcontext.iOS`mono_de_process_breakpoint(void_tls=0x0000000149014e00, from_signal=0) at debugger-engine.c:1141:2 frame #8: 0x000000010430f238 reloadcontext.iOS`debugger_agent_breakpoint_from_context(ctx=0x000000016f656790) at debugger-agent.c:4938:2 frame #9: 0x00000001011b73a4 reloadcontext.iOS`sdb_breakpoint_trampoline + 148 frame #10: 0x00000001008511b4 reloadcontext.iOS`reloadcontext_iOS_Application_Main_string__(args=0x000000010703a030) at Main.cs:14 frame #11: 0x00000001010f9730 reloadcontext.iOS`wrapper_runtime_invoke_object_runtime_invoke_dynamic_intptr_intptr_intptr_intptr + 272 frame #12: 0x00000001042fd8b8 reloadcontext.iOS`mono_jit_runtime_invoke(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, exc=0x0000000000000000, error=0x000000016f656ff8) at mini-runtime.c:3162:3 frame #13: 0x0000000104411950 reloadcontext.iOS`do_runtime_invoke(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, exc=0x0000000000000000, error=0x000000016f656ff8) at object.c:3052:11 frame #14: 0x000000010440c4dc reloadcontext.iOS`mono_runtime_invoke_checked(method=0x0000000145d09ae8, obj=0x0000000000000000, params=0x000000016f656f20, error=0x000000016f656ff8) at object.c:3220:9 frame dotnet#15: 0x0000000104415ae0 reloadcontext.iOS`do_exec_main_checked(method=0x0000000145d09ae8, args=0x000000010703a030, error=0x000000016f656ff8) at object.c:5184:3 frame dotnet#16: 0x00000001044144ac reloadcontext.iOS`mono_runtime_exec_main_checked(method=0x0000000145d09ae8, args=0x000000010703a030, error=0x000000016f656ff8) at object.c:5281:9 frame dotnet#17: 0x0000000104414500 reloadcontext.iOS`mono_runtime_run_main_checked(method=0x0000000145d09ae8, argc=1, argv=0x000000016f6570d0, error=0x000000016f656ff8) at object.c:4734:9 frame dotnet#18: 0x00000001042d3b54 reloadcontext.iOS`mono_jit_exec_internal(domain=0x0000000145f00130, assembly=0x0000000281ba2900, argc=1, argv=0x000000016f6570d0) at driver.c:1320:13 frame dotnet#19: 0x00000001042d39a4 reloadcontext.iOS`mono_jit_exec(domain=0x0000000145f00130, assembly=0x0000000281ba2900, argc=1, argv=0x000000016f6570d0) at driver.c:1265:7 frame dotnet#20: 0x0000000104597994 reloadcontext.iOS`::xamarin_main(argc=5, argv=0x000000016f657a80, launch_mode=XamarinLaunchModeApp) at monotouch-main.m:483:8 frame dotnet#21: 0x00000001008510dc reloadcontext.iOS`main(argc=5, argv=0x000000016f657a80) at main.m:104:11 frame dotnet#22: 0x0000000190af8360 libdyld.dylib`start + 4 [...] * thread #5, name = 'Debugger agent', stop reason = signal SIGABRT * frame #0: 0x0000000190aedec4 libsystem_kernel.dylib`__pthread_kill + 8 frame #1: 0x0000000190a0d724 libsystem_pthread.dylib`pthread_kill$VARIANT$armv81 + 216 frame #2: 0x000000019095d844 libsystem_c.dylib`abort + 100 frame #3: 0x00000001045871b4 reloadcontext.iOS`log_callback(log_domain=0x0000000000000000, log_level="error", message="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n", fatal=4, user_data=0x0000000000000000) at runtime.m:1213:3 frame #4: 0x0000000104544fc8 reloadcontext.iOS`eglib_log_adapter(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, message="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n", user_data=0x0000000000000000) at mono-logger.c:405:2 frame #5: 0x000000010456093c reloadcontext.iOS`monoeg_g_logstr(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, msg="* Assertion at ../../../../../mono/mini/interp/interp.c:7176, condition `context' not met\n") at goutput.c:134:2 frame #6: 0x0000000104560598 reloadcontext.iOS`monoeg_g_logv_nofree(log_domain=0x0000000000000000, log_level=G_LOG_LEVEL_ERROR, format="* Assertion at %s:%d, condition `%s' not met\n", args="e\x12z\x04\x01") at goutput.c:149:2 frame #7: 0x000000010456061c reloadcontext.iOS`monoeg_assertion_message(format="* Assertion at %s:%d, condition `%s' not met\n") at goutput.c:184:22 frame #8: 0x0000000104560674 reloadcontext.iOS`mono_assertion_message(file="../../../../../mono/mini/interp/interp.c", line=7176, condition="context") at goutput.c:203:2 frame #9: 0x000000010459b570 reloadcontext.iOS`interp_get_resume_state(jit_tls=0x000000014900d000, has_resume_state=0x000000016fc7a9f4, interp_frame=0x000000016fc7a9e8, handler_ip=0x000000016fc7a9e0) at interp.c:7176:2 frame #10: 0x0000000104319420 reloadcontext.iOS`compute_frame_info(thread=0x0000000104fe4130, tls=0x0000000149014e00, force_update=1) at debugger-agent.c:3422:3 frame #11: 0x0000000104320d40 reloadcontext.iOS`thread_commands(command=1, p="", end="", buf=0x000000016fc7acf8) at debugger-agent.c:9048:3 frame #12: 0x000000010431cca0 reloadcontext.iOS`debugger_thread(arg=0x0000000000000000) at debugger-agent.c:10132:10 frame #13: 0x000000010447eb04 reloadcontext.iOS`start_wrapper_internal(start_info=0x0000000000000000, stack_ptr=0x000000016fc7b000) at threads.c:1232:3 frame #14: 0x000000010447e788 reloadcontext.iOS`start_wrapper(data=0x000000028203ef40) at threads.c:1305:8 frame dotnet#15: 0x0000000190a11d8c libsystem_pthread.dylib`_pthread_start + 15 [...] ``` Thanks to @drasticactions for helping me to reproduce. Fixes https://devdiv.visualstudio.com/DevDiv/_workitems/edit/1050615 <!-- Thank you for your Pull Request! If you are new to contributing to Mono, please try to do your best at conforming to our coding guidelines http://www.mono-project.com/community/contributing/coding-guidelines/ but don't worry if you get something wrong. One of the project members will help you to get things landed. Does your pull request fix any of the existing issues? Please use the following format: Fixes #issue-number --> Co-authored-by: Bernhard Urban-Forster <bernhard.urban@xamarin.com>
trylek pushed a commit that referenced this pull request Feb 13, 2020
Fix unhandled exception line number issues There are a few paths to get the place (DebugStackTrace::DebugStackTraceElement::InitPass2) where the offset/ip needs an adjustment: 1) The System.Diagnostics.StackTrace constructors that take an exception object. The stack trace in the exception object is used (from the _stackTrace field). 2) Processing an unhandled exception for display (ExceptionTracker::ProcessOSExceptionNotification). 3) The System.Diagnostics.StackTrace constructors that don't take an exception object that get the stack trace of the current thread. For cases #1 and #2 the StackTraceInfo/StackTraceElement structs are built when the stack trace for an exception is generated and is put in the private _stackTrace Exception object field. The IP in each StackTraceElement is decremented for hardware exceptions and not for software exceptions because the CrawlFrame isInterrupted/hasFaulted fields are not initialized (always false). This is backwards for h/w exceptions leaf node frames but really can't be changed to be compatible with other code in the runtime and SOS. The fIsLastFrameFromForeignStackTrace BOOL in the StackTraceElement/DebugStackTraceElement structs have been replaced with INT "flags" field defined by the StackTraceElementFlags enum. There is a new flag that is set (STEF_IP_ADJUSTED) if the IP has been already adjusted/decremented. This flag is used to adjust the native offset when it is converted to an IL offset for source/line number lookup in DebugStackTraceElement::InitPass2(). When the stack trace for an exception is rendered to a string (via the GetStackFramesInternal FCALL) the internal GetStackFramesData/DebugStackTraceElement structs are initialized. This new "flags" field is passed from the StackTraceElement to the DebugStackTraceElement struct. For case #3 all this happens in the GetStackFramesInternal FCALL called from the managed constructor building the GetStackFramesData/DebugStackTraceElement structs directly. Fixes issues dotnet#27765 and dotnet#25740. Fix IL offset map search.
Youssef1313 pushed a commit that referenced this pull request Jul 13, 2022
E.g., Update LSRA "Allocating Registers" table description. Dump nodes added during resolution, e.g.: ``` BB29 bottom (BB08->BB08): move V25 from STK to rdi (Critical) N001 ( 1, 1) [001174] ----------z t1174 = LCL_VAR int V25 cse4 rdi REG rdi ``` Dump more data in the LSRA block sequence data: ``` -BB03( 16 ) -BB04( 4 ) +BB03 ( 16 ) critical-in critical-out +BB04 ( 4 ) critical-out ``` When dumping various flow bitvectors, annotate the bitvectors better: ``` -BB25 in gen out -0000000000000000 -0000000000000003 CSE #1.c -0000000000000003 CSE #1.c +BB25 + in: 0000000000000000 +gen: 0000000000000003 CSE #1.c +out: 0000000000000003 CSE #1.c ``` Dump hoisting bitvectors using the sorting number: ``` - USEDEF (5)={V04 V00 V01 V02 V03} + USEDEF (5)={V00 V01 V02 V03 V04} ``` Also, fix various typos and formatting.
Youssef1313 pushed a commit that referenced this pull request Oct 15, 2022
* WIP: add gRPC tests * Fix AOT and trimming * WIP * Implement IncludeNetworkSecurityConfig * Use IncludeNetworkSecurityConfig * Fix gRPC test * Avoid git checkout * Remove unnecessary code * WIP: start working on CI configuration * Remove WinHttpHandler * Fix problem with SSL * Change server host * Setup CI (#1) * Get Docker container building & exported via test build * Changes * Add missing pfx certificate * changes * cleanup Co-authored-by: Simon Rozsival <simon@rozsival.com> * Use tls * Update yml * Revert changes to the mono Android sample app * Bump android image version * Bump image version * Enable TLS * Remove hardcoded package versions * Update package versions * Update package versions * Rename pipeline * Move interop tests website dependencies versions to Versions.props * Add cred scan supression for the interop test server private key * Fix licenses * Remove dependencies * Fix path to Versions.props * Remove unnecessary dependency version * Fix building docker image * Change pfx password Co-authored-by: Jo Shields <directhex@apebox.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Beep boop. Your images are optimized!
Your image file size has been reduced by 23% 🎉
Details
📝docs |
repo | 🙋issues | 🏅swag | 🏪marketplace