Playground CLI: Skip WP install when using existing WP files #2616
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
brandonpayton added [Type] Bug 
| @adamziel, the small change in this PR makes sense to me, but I'm concerned that I could be forgetting a valid use case for the current behavior. Is there any reason this change does not make sense? |
| With this change, the Playground CLI no longet refuses to boot when there is a DB config issue and When I believe this is the desired behavior. |
| I also think this change makes sense, thank you @brandonpayton! |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Playground CLI will refuse to boot for an existing WP site due to a WP install failure even when
--skip-wordpress-setupis enabled.This is a PR to fix that.
Implementation details
In the bootWordPress() function, do not perform WP installation if no
wordpressZipis provided.Testing Instructions (or ideally a Blueprint)