Skip flaky e2e tests in Firefox and Webkit #2425
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
adamziel added [Type] Enhancement 
| There's still that one flaky case in |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Skips the two tests responsible for most failed CI runs:
HTTPS requests via curl_exec() should workin Firefox and WebkitShould translate WP-admin to Spanish for the nightly/beta WordPress buildin Firefox and WebkitThe scenarios pass in Chrome and also work in manual testing on localhost and playground.wordpress.net. While finding the root cause will be highly useful, accepting a red X as the norm is highly unuseful and makes us miss actual failures.
Testing instructions
Confirm the CI checks pass.
FYI @brandonpayton @zaerl @JanJakes @fellyph