Enable separate source maps for all package builds #2088
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| Seems like there's a linting issue stopping the other CI checks |
| @brandonpayton It seems like this PR added source maps to the list of mandatory downloads at https://playground.wordpress.net/assets-required-for-offline-mode.json: [ "/assets/_virtual_cors-proxy-url-565333ec.js", "/assets/_virtual_cors-proxy-url-565333ec.js.map", "/assets/brain-1418d665.svg", "/assets/builder/builder.html-20166f80.js", "/assets/builder/builder.html-20166f80.js.map", "/assets/builder-0648a1dd.css", "/assets/builder-e4f9112a.js", "/assets/builder-e4f9112a.js.map", "/assets/client-3dcfb6e9.js", "/assets/client-3dcfb6e9.js.map",Let's remove them as they can be quite large. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
Enabling source map generation for production builds would make it easier to debug Playground in production.
Implementation details
I edited all vite.config.js files and added
sourcemap: trueto generate separate source maps files for all package builds. Keeping separate source maps should allow us to only pay the cost for downloading them when actively debugging.Testing Instructions (or ideally a Blueprint)