Fix path of PR preview URL in production #2014
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
| note: There are e2e test failures, but they seem to be the same as we were already seeing on trunk. Let's merge this. |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
This fixes a problem with the PR preview URLs created by the PR preview modals in production.
Before this fix, a preview URL created by the modal in production looks like
cc @ajotka
Implementation details
This PR uses the current app location path as a basis for the PR preview URL.
Testing Instructions (or ideally a Blueprint)
npm run devnpm run build, runphp -S localhost:8888 -t dist/packages/playground/wasm-wordpress-net, and manually test PR preview for WP PRs