Skip to content

[CLI] Restore the "login" argument handler #1985

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 5, 2024
Merged

[CLI] Restore the "login" argument handler #1985

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
236c236
Revert login remove
bgrgicak Nov 5, 2024
18e4700
Update debug parameter description
bgrgicak Nov 5, 2024
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/playground/cli/src/cli.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@ async function run() {
})
.option('debug', {
describe:
'Return PHP error log content if an error occurs while building the site.',
'Print PHP error log content if an error occurs during Playground boot.',
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related discussion #1983 (comment)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! a --debug flag that doesn't cover the entire lifecycle of the app seems confusing to me. What do you think about either renameing it to --debug-boot or making it work after the boot?
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add request debugging. Here is an issue to track it #1988
type: 'boolean',
default: false,
})
Expand Down Expand Up @@ -215,6 +215,7 @@ async function run() {
php: args.php as SupportedPHPVersion,
wp: args.wp,
},
login: args.login,
};
}

Expand Down