[Blueprints] Skip empty lines in the runSql step #1939
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Skips the empty SQL lines in the runSql Blueprint step. Before this PR, the step handler was very strict and would error out on the first empty or semicolon-only line. While I was on it, I split the unit tests into three distinct cases and simplified the SQL running logic. This SQL file wouldn't work before this PR but it works after it: ```sql SELECT * FROM wp_users; ; SELECT * FROM wp_users; ``` ## Testing instructions CI
adamziel added [Type] Enhancement Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Skips the empty SQL lines in the runSql Blueprint step. Before this PR, the step handler was very strict and would error out on the first empty or semicolon-only line. While I was on it, I split the unit tests into three distinct cases and simplified the SQL running logic.
This SQL file wouldn't work before this PR but it works after it:
Testing instructions
CI
cc @akirk