CORS Proxy: Reject targeting self #1932
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
brandonpayton added [Type] Bug 
adamziel reviewed Oct 23, 2024
| ( isset( $_SERVER['SERVER_ADDR'] ) && | ||
| strcasecmp($_SERVER['SERVER_ADDR'], $host) === 0) | ||
| ) { | ||
| throw new CorsProxyException("URL cannot target the CORS proxy host."); |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit. This suggestion is invalid because no changes were made to the code. Suggestions cannot be applied while the pull request is closed. Suggestions cannot be applied while viewing a subset of changes. Only one suggestion per line can be applied in a batch. Add this suggestion to a batch that can be applied as a single commit. Applying suggestions on deleted lines is not supported. You must change the existing code in this line in order to create a valid suggestion. Outdated suggestions cannot be applied. This suggestion has been applied or marked resolved. Suggestions cannot be applied from pending reviews. Suggestions cannot be applied on multi-line comments. Suggestions cannot be applied while the pull request is queued to merge. Suggestion cannot be applied right now. Please check back later.
Motivation for the change, related issues
The CORS proxy shouldn't be able to target itself, so this PR rejects requests that attempt to do so.
Closes #1919
Implementation details
This PR checks the
$_SERVER['HTTP_HOST'and$_SERVER['SERVER_ADDR']and rejects the request if the target host matches either.Testing Instructions (or ideally a Blueprint)