Skip to content

Conversation

brandonpayton
Copy link
Member

@brandonpayton brandonpayton commented Oct 10, 2024

Motivation for the change, related issues

This PR updates the Playground website build to include the CORS proxy.

The proxy is not quite ready for broad use yet. The following issues need to be addressed:

But, @adamziel, if desired and if you are comfortable with the risk, you could merge this and deploy the CORS proxy now to enable initial testing.

Implementation details

This updates nx project descriptions to include php-cors-proxy scripts with the Playground website builds.

Testing Instructions (or ideally a Blueprint)

  • Run npx nx build playground-website
  • Run ls dist/packages/playground/wasm-wordpress-net/ | grep cors-proxy and confirm cors-proxy.php and cors-proxy-functions.php are present.
@brandonpayton
Copy link
Member Author

I'm planning to troubleshoot the "cannot parse response" Safari error w/ CORS proxy separately.

@brandonpayton brandonpayton merged commit 561525f into trunk Oct 14, 2024
9 checks passed
@brandonpayton brandonpayton deleted the deploy-cors-proxy-with-website branch October 14, 2024 23:40
@brandonpayton brandonpayton restored the deploy-cors-proxy-with-website branch October 14, 2024 23:53
@brandonpayton brandonpayton deleted the deploy-cors-proxy-with-website branch October 14, 2024 23:53
brandonpayton added a commit that referenced this pull request Oct 14, 2024
This code was accidentally committed as part of PR #1880.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment